Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resolving target platform projects #3280

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 17, 2023

Currently target-platform projects do not have any resolved dependencies, this has a few disadvantages:

  • if one want to see the dependency tree it is empty
  • if one wants to mirror a target platform this can't be performed

This adds support for target platform projects to resolve and have their dependencies injected to support such advanced use-cases.

Copy link

github-actions bot commented Dec 17, 2023

Test Results

   576 files  ±0     576 suites  ±0   3h 23m 10s ⏱️ - 6m 16s
   380 tests ±0     373 ✔️  - 1    6 💤 ±0  1 +1 
1 140 runs  ±0  1 120 ✔️  - 1  19 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 62523f1. ± Comparison against base commit 77acf50.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the resolve_target_platform_projects branch from 18e2c73 to 41b1b4f Compare December 17, 2023 11:45
Currently target-platform projects do not have any resolved
dependencies, this has a few disadvantages:

- if one want to see the dependency tree it is empty
- if one wants to mirror a target platform this can't be performed

This adds support for target platform projects to resolve and have their
dependencies injected to support such advanced use-cases.
@laeubi laeubi force-pushed the resolve_target_platform_projects branch from 41b1b4f to 62523f1 Compare December 17, 2023 17:39
@laeubi laeubi marked this pull request as ready for review December 17, 2023 17:43
@laeubi laeubi merged commit d252b9c into eclipse-tycho:main Dec 18, 2023
8 of 10 checks passed
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Dec 18, 2023
Copy link

💔 All backports failed

Status Branch Result
tycho-4.0.x Backport failed because of merge conflicts

You might need to backport the following PRs to tycho-4.0.x:
- Register TargetPlatformFactory as a component
- Support repository references

Manual backport

To create the backport manually run:

backport --pr 3280

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant