Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tycho-4.0.x] Don't warn if mapping p2 dependencies is not enabled #3455

Merged
merged 1 commit into from
Feb 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,16 @@ public void execute() throws MojoExecutionException, MojoFailureException {
}
if (p2Skipped.isEmpty()) {
log.info("All system scoped dependencies were mapped to maven artifacts");
} else {
} else if (mapP2Dependencies) {
log.warn(resolved + " system scoped dependencies were mapped to maven artifacts, " + p2Skipped.size()
+ " were skipped");
if (log.isDebugEnabled()) {
for (String skipped : p2Skipped) {
log.debug("Skipped: " + skipped);
}
}
} else {
log.info(p2Skipped.size() + " system scoped dependencies were not mapped to maven artifacts");
}
try {
modelWriter.write(output, null, projectModel);
Expand Down