[tycho-4.0.x] assemble-repository: Prevent sources from being included inadvertently #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the presence of products, P2 adds a virtual 'tooling.source.default'
IU which optionally depends on all sources.
If these sources are available in the target platform, this would cause
them to be picked up even if assemble-repository was configured with
<includeAllDependencies>true<includeAllDependencies>
but with
<includeAllSources>false</includeAllSources>.
This scenario has become much more likely with recent changes to P2 [1].
We do not want includeAllDependencies to imply includeAllSources, so
we actively prevent this from happening by ignoring the
<required namespace='org.eclipse.equinox.p2.eclipse.type'
name='source'
range='0.0.0'
optional='true'
multiple='true'
greedy='false'/>
requirements if 'includeAllSources' is not specified.
Fixes #3522.
[1] eclipse-equinox/p2#446
(cherry picked from commit 51e39d6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintotycho-4.0.x:Questions ?
Please refer to the Backport tool documentation