Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.cyclonedx:cyclonedx-maven-plugin from 2.8.0 to 2.8.1 #4085

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 5, 2024

Bumps org.cyclonedx:cyclonedx-maven-plugin from 2.8.0 to 2.8.1.

Release notes

Sourced from org.cyclonedx:cyclonedx-maven-plugin's releases.

2.8.1

🚀 New features and improvements

📦 Dependency updates

Commits
  • 2de88e5 [maven-release-plugin] prepare release cyclonedx-maven-plugin-2.8.1
  • 1510a02 upgrade cyclonedx-maven-plugin from 2.7.9 to 2.8.0
  • 448d117 Bump net.javacrumbs.json-unit:json-unit-assertj from 2.38.0 to 2.40.1
  • cfcf26b Bump org.apache.maven.plugins:maven-release-plugin from 3.0.1 to 3.1.1
  • f95fe87 Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.7.0 to 3.8.0
  • 4ee61c3 Bump org.junit:junit-bom from 5.10.2 to 5.10.3
  • 8eb5316 Bump org.apache.maven.plugins:maven-jar-plugin from 3.4.1 to 3.4.2
  • 4c77122 replace CDX 1.5 deprecated tool
  • 7f34a10 Bump plugin-tools.version from 3.13.0 to 3.13.1
  • ab713bb Bump org.apache.maven.plugins:maven-project-info-reports-plugin
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 5, 2024
@github-actions github-actions bot enabled auto-merge (rebase) August 5, 2024 23:31
Copy link

github-actions bot commented Aug 5, 2024

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/10257548464

Copy link

github-actions bot commented Aug 6, 2024

Test Results

  600 files  ±0    600 suites  ±0   3h 58m 1s ⏱️ - 12m 19s
  429 tests ±0    421 ✅ +5   7 💤 ±0  0 ❌  - 3  1 🔥  - 2 
1 287 runs  ±0  1 264 ✅ +5  22 💤 ±0  0 ❌  - 3  1 🔥  - 2 

For more details on these errors, see this check.

Results for commit bbb8baf. ± Comparison against base commit 4b50ecf.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

/request-license-review

Copy link

github-actions bot commented Aug 6, 2024

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/10260445774

@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.cyclonedx-cyclonedx-maven-plugin-2.8.1 branch from 037a560 to 7041c84 Compare August 6, 2024 04:53
Copy link

github-actions bot commented Aug 6, 2024

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/10260480997

@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.cyclonedx-cyclonedx-maven-plugin-2.8.1 branch from 7041c84 to dcf1b7e Compare August 8, 2024 06:02
@laeubi
Copy link
Member

laeubi commented Aug 12, 2024

@ptziegler it seems the Tycho integration do not work anymore with that update can you have a look?

@ptziegler
Copy link
Contributor

I find it a little disturbing that the build succeeds in the first place...

Updating to 2.8.1 seems to mess with the dependent Maven plugin and as a result, the build should fail with the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project tycho-sbom: Compilation failure: Compilation failure: 
[ERROR] /home/patrick/Eclipse/tycho-main/git/tycho/tycho-sbom/src/main/java/org/eclipse/tycho/sbom/TychoModelConverter.java:[25,24] package org.apache.maven does not exist
[ERROR] /home/patrick/Eclipse/tycho-main/git/tycho/tycho-sbom/src/main/java/org/eclipse/tycho/sbom/TychoModelConverter.java:[26,34] package org.apache.maven.execution does not exist
[ERROR] /home/patrick/Eclipse/tycho-main/git/tycho/tycho-sbom/src/main/java/org/eclipse/tycho/sbom/TychoModelConverter.java:[27,31] cannot find symbol
[ERROR]   symbol:   class LegacySupport
[ERROR]   location: package org.apache.maven.plugin
...

For reference, this is the dependency tree with 2.8.0:
image

And this with 2.8.1:
image

I have no clue what the test is executed with, but I highly doubt it's an up-to-date version of this project. Scary...

The maven-core dependency used to be contributed by CycloneDX:

[INFO] \- org.cyclonedx:cyclonedx-maven-plugin:jar:2.8.0:compile
[INFO]    +- org.cyclonedx:cyclonedx-core-java:jar:8.0.3:compile
[INFO]    |  +- com.github.package-url:packageurl-java:jar:1.4.1:compile
[INFO]    |  +- com.fasterxml.jackson.dataformat:jackson-dataformat-xml:jar:2.15.3:compile
[INFO]    |  |  +- com.fasterxml.jackson.core:jackson-core:jar:2.15.3:compile
[INFO]    |  |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.15.3:compile
[INFO]    |  |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.15.3:compile
[INFO]    |  |  +- org.codehaus.woodstox:stax2-api:jar:4.2.1:compile
[INFO]    |  |  \- com.fasterxml.woodstox:woodstox-core:jar:6.5.1:compile
[INFO]    |  \- com.networknt:json-schema-validator:jar:1.0.87:compile
[INFO]    |     +- com.ethlo.time:itu:jar:1.7.0:compile
[INFO]    |     \- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.15.2:compile
[INFO]    |        \- org.yaml:snakeyaml:jar:2.0:compile
[INFO]    +- org.apache.commons:commons-lang3:jar:3.16.0:compile
[INFO]    +- org.apache.maven.shared:maven-dependency-tree:jar:3.2.1:compile
[INFO]    |  \- org.eclipse.aether:aether-util:jar:1.0.0.v20140518:compile
[INFO]    |     \- org.eclipse.aether:aether-api:jar:1.0.0.v20140518:compile
[INFO]    \- org.apache.maven.shared:maven-dependency-analyzer:jar:1.13.2:compile
[INFO]       +- org.apache.maven:maven-core:jar:3.9.8:provided
[INFO]       |  +- org.apache.maven:maven-settings:jar:3.9.8:provided
[INFO]       |  +- org.apache.maven:maven-settings-builder:jar:3.9.8:provided
[INFO]       |  |  \- org.codehaus.plexus:plexus-sec-dispatcher:jar:2.0:provided
[INFO]       |  +- org.apache.maven:maven-builder-support:jar:3.9.8:provided
[INFO]       |  +- org.apache.maven:maven-repository-metadata:jar:3.9.8:provided
[INFO]       |  +- org.apache.maven:maven-model-builder:jar:3.9.8:provided
[INFO]       |  +- org.apache.maven:maven-resolver-provider:jar:3.9.8:provided
[INFO]       |  +- org.apache.maven.resolver:maven-resolver-impl:jar:1.9.20:provided
[INFO]       |  |  \- org.apache.maven.resolver:maven-resolver-named-locks:jar:1.9.20:provided
[INFO]       |  +- org.apache.maven.resolver:maven-resolver-spi:jar:1.9.20:provided
[INFO]       |  +- org.apache.maven.shared:maven-shared-utils:jar:3.4.2:provided
[INFO]       |  +- com.google.inject:guice:jar:5.1.0:provided
[INFO]       |  |  \- aopalliance:aopalliance:jar:1.0:provided
[INFO]       |  +- com.google.guava:guava:jar:33.2.1-jre:provided
[INFO]       |  \- com.google.guava:failureaccess:jar:1.0.2:provided
[INFO]       \- org.ow2.asm:asm:jar:9.5:compile

This dependency no longer exists:

[INFO] \- org.cyclonedx:cyclonedx-maven-plugin:jar:2.8.1:compile
[INFO]    +- org.cyclonedx:cyclonedx-core-java:jar:8.0.3:compile
[INFO]    |  +- com.github.package-url:packageurl-java:jar:1.4.1:compile
[INFO]    |  +- com.fasterxml.jackson.dataformat:jackson-dataformat-xml:jar:2.15.3:compile
[INFO]    |  |  +- com.fasterxml.jackson.core:jackson-core:jar:2.15.3:compile
[INFO]    |  |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.15.3:compile
[INFO]    |  |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.15.3:compile
[INFO]    |  |  +- org.codehaus.woodstox:stax2-api:jar:4.2.1:compile
[INFO]    |  |  \- com.fasterxml.woodstox:woodstox-core:jar:6.5.1:compile
[INFO]    |  \- com.networknt:json-schema-validator:jar:1.0.87:compile
[INFO]    |     +- com.ethlo.time:itu:jar:1.7.0:compile
[INFO]    |     \- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.15.2:compile
[INFO]    |        \- org.yaml:snakeyaml:jar:2.0:compile
[INFO]    +- org.apache.commons:commons-lang3:jar:3.16.0:compile
[INFO]    +- org.apache.maven.shared:maven-dependency-tree:jar:3.3.0:compile
[INFO]    \- org.apache.maven.shared:maven-dependency-analyzer:jar:1.14.1:compile
[INFO]       \- org.ow2.asm:asm:jar:9.7:compile

Let me check real quick whether that alone is sufficient to fix this problem...

ptziegler added a commit to ptziegler/tycho that referenced this pull request Aug 12, 2024
This dependency is indirectly contributed by CycloneDX 2.8.0, but not by
2.8.1. Given that it is required for compilation and to avoid errors
when updating this library, is it now added as an explicit dependency.

See eclipse-tycho#4085
@ptziegler
Copy link
Contributor

See #4106. At least locally, this seems to have been enough to fix the test.

laeubi pushed a commit that referenced this pull request Aug 12, 2024
This dependency is indirectly contributed by CycloneDX 2.8.0, but not by
2.8.1. Given that it is required for compilation and to avoid errors
when updating this library, is it now added as an explicit dependency.

See #4085
eclipse-tycho-bot pushed a commit that referenced this pull request Aug 12, 2024
This dependency is indirectly contributed by CycloneDX 2.8.0, but not by
2.8.1. Given that it is required for compilation and to avoid errors
when updating this library, is it now added as an explicit dependency.

See #4085

(cherry picked from commit b41ef88)
eclipse-tycho-bot pushed a commit that referenced this pull request Aug 12, 2024
This dependency is indirectly contributed by CycloneDX 2.8.0, but not by
2.8.1. Given that it is required for compilation and to avoid errors
when updating this library, is it now added as an explicit dependency.

See #4085

(cherry picked from commit b41ef88)
@laeubi
Copy link
Member

laeubi commented Sep 12, 2024

@dependabot rebase

Bumps [org.cyclonedx:cyclonedx-maven-plugin](https://github.com/CycloneDX/cyclonedx-maven-plugin) from 2.8.0 to 2.8.1.
- [Release notes](https://github.com/CycloneDX/cyclonedx-maven-plugin/releases)
- [Commits](CycloneDX/cyclonedx-maven-plugin@cyclonedx-maven-plugin-2.8.0...cyclonedx-maven-plugin-2.8.1)

---
updated-dependencies:
- dependency-name: org.cyclonedx:cyclonedx-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.cyclonedx-cyclonedx-maven-plugin-2.8.1 branch from dcf1b7e to bbb8baf Compare September 12, 2024 05:38
@github-actions github-actions bot merged commit b42fcc0 into main Sep 12, 2024
8 of 11 checks passed
@dependabot dependabot bot deleted the dependabot/maven/org.cyclonedx-cyclonedx-maven-plugin-2.8.1 branch September 12, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants