Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating (sub)incremental versions #4178

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Aug 24, 2024

Currently due to how the underlying library works, if there is only a micro version update it is not considered. Also subincremental versions are only taken into account if major is allowed (what currently include all increments) what is inconsistent.

This now changes the single optional to a stream in order of update hierarchy and let the MavenLocationUpdater choose the first matching update offered and adding an option for subincremental updates as well.

Currently due to how the underlying library works, if there is only a
micro version update it is not considered. Also subincremental versions
are only taken into account if major is allowed (what currently include
all increments) what is inconsistent.

This now changes the single optional to a stream in order of update
hierarchy and let the MavenLocationUpdater choose the first matching
update offered and adding an option for subincremental updates as well.
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Aug 24, 2024
@laeubi laeubi enabled auto-merge (rebase) August 24, 2024 05:58
Copy link

Test Results

  600 files  ±0    600 suites  ±0   4h 7m 48s ⏱️ - 19m 3s
  429 tests ±0    422 ✅ ±0   7 💤 ±0  0 ❌ ±0 
1 287 runs  ±0  1 265 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit c8a9954. ± Comparison against base commit 359c1b0.

@laeubi laeubi merged commit 3f002a6 into eclipse-tycho:main Aug 24, 2024
12 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants