Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #707 - fix logic detecting custom vs none EE profile #709

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

mickaelistria
Copy link
Contributor

Fix some methods and conditions to better distinguish cases of ee=none
vs custom EE.
This allows further invocations of
TargetPlatformFactoryImpl.createTargetPlatform to work with ee=none.

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Unit Test Results

151 files  151 suites   58m 49s ⏱️
254 tests 251 ✔️ 3 💤 0

Results for commit 910bda6.

♻️ This comment has been updated with latest results.

Fix some methods and conditions to better distinguish cases of ee=none
vs custom EE.
This allows further invocations of
TargetPlatformFactoryImpl.createTargetPlatform to work with ee=none.
@mickaelistria mickaelistria merged commit 910bda6 into eclipse-tycho:master Mar 1, 2022
@laeubi laeubi added this to the 3.0 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compare-versions-with-baseline failing (since 2.7) when executionEnvironment=none
2 participants