Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Reproduce generation of existing gRPC stubs #94

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

BjoernAtBosch
Copy link
Member

Describe your changes

The process to generate the data broker gRPC stubs from the corresponding proto files is not working as it is described in CONTRIBUTING.md. This fix provides a working solution.

Issue ticket number and link

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

Copy link
Contributor

@kse3hi kse3hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BjoernAtBosch BjoernAtBosch merged commit 7ad9e5c into main Aug 15, 2023
6 checks passed
@BjoernAtBosch BjoernAtBosch deleted the fix/reproduce_grpc_stubs_gen branch August 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants