Creation of DefaultChannelGroup should specify was actually incorrec…

…t: newly added channels were simply added to the group after a group close, instead they should be closed when they are added when the group is closed
eclipse-vertx · Mar 7, 2024 · 7875eba · 7875eba
1 parent e888bde
commit 7875eba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/io/vertx/core/net/impl/NetClientImpl.java b/src/main/java/io/vertx/core/net/impl/NetClientImpl.java
@@ -78,7 +78,7 @@ public class NetClientImpl implements MetricsProvider, NetClient, Closeable {
 
   public NetClientImpl(VertxInternal vertx, TCPMetrics metrics, NetClientOptions options, CloseFuture closeFuture) {
     this.vertx = vertx;
-    this.channelGroup = new DefaultChannelGroup(vertx.getAcceptorEventLoopGroup().next());
+    this.channelGroup = new DefaultChannelGroup(vertx.getAcceptorEventLoopGroup().next(), true);
     this.options = new NetClientOptions(options);
     this.sslHelper = new SSLHelper(options, options.getApplicationLayerProtocols());
     this.metrics = metrics;

diff --git a/src/main/java/io/vertx/core/net/impl/ServerChannelLoadBalancer.java b/src/main/java/io/vertx/core/net/impl/ServerChannelLoadBalancer.java
@@ -40,7 +40,7 @@ class ServerChannelLoadBalancer extends ChannelInitializer<Channel> {
 
   ServerChannelLoadBalancer(EventExecutor executor) {
     this.workers = new VertxEventLoopGroup();
-    this.channelGroup = new DefaultChannelGroup(executor);
+    this.channelGroup = new DefaultChannelGroup(executor, true);
   }
 
   public VertxEventLoopGroup workers() {