Add support for MariaDB and migrate MySQL testing to TestContainers #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before accepting this PR we need to do Eclipse CQ for test containers |
|
@vietj how about migrating all the databases to Testcontainers some time later? Our MSSQL tests will use the that and the embedded Postgres is not maintained anymore, if we drop using the embedded databases we will then have only one dependency on the testcontainers. |
|
yes we could do that I think, it looks to work reasonably well. |
|
@vietj do we have a green light now on the CQ for this to be merged? |
|
no we need a works-with CQ first, I will do it tomorrow |
|
It seems the PMC has approved the CQ request, can you please take a look at this? |
|
the IP team needs to give a go as well |
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
…ment parameters Signed-off-by: Billy Yuan <billy112487983@gmail.com>
…ounding for fractional seconds Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
BillyYccc
force-pushed
the
mariadb-support
branch
from
4c9a324 to
02025e0
Compare
BillyYccc
changed the title
|
I have reworked the PR and add the migrations to testcontainers for MySQL here. |
|
@vietj PTAL |
BillyYccc
added a commit
to BillyYccc/vertx-sql-client
that referenced
this pull request
Aug 30, 2019
…clipse-vertx#381) * add support for testing with MariaDB Signed-off-by: Billy Yuan <billy112487983@gmail.com> * do not use null since the datatype will be used for the prepare statement parameters Signed-off-by: Billy Yuan <billy112487983@gmail.com> * skip the test for MariaDB because it does not support automatically rounding for fractional seconds Signed-off-by: Billy Yuan <billy112487983@gmail.com> * add connection URI support for MariaDB Signed-off-by: Billy Yuan <billy112487983@gmail.com> * travis setup Signed-off-by: Billy Yuan <billy112487983@gmail.com> * update documentation Signed-off-by: Billy Yuan <billy112487983@gmail.com> * TestContainers migration for MySQL tests Signed-off-by: Billy Yuan <billy112487983@gmail.com> * use single init SQL script for MySQL Signed-off-by: Billy Yuan <billy112487983@gmail.com> * boost MySQL testing with the shared instance Signed-off-by: Billy Yuan <billy112487983@gmail.com>
vietj
pushed a commit
that referenced
this pull request
Sep 9, 2019
…381) * add support for testing with MariaDB Signed-off-by: Billy Yuan <billy112487983@gmail.com> * do not use null since the datatype will be used for the prepare statement parameters Signed-off-by: Billy Yuan <billy112487983@gmail.com> * skip the test for MariaDB because it does not support automatically rounding for fractional seconds Signed-off-by: Billy Yuan <billy112487983@gmail.com> * add connection URI support for MariaDB Signed-off-by: Billy Yuan <billy112487983@gmail.com> * travis setup Signed-off-by: Billy Yuan <billy112487983@gmail.com> * update documentation Signed-off-by: Billy Yuan <billy112487983@gmail.com> * TestContainers migration for MySQL tests Signed-off-by: Billy Yuan <billy112487983@gmail.com> * use single init SQL script for MySQL Signed-off-by: Billy Yuan <billy112487983@gmail.com> * boost MySQL testing with the shared instance Signed-off-by: Billy Yuan <billy112487983@gmail.com>
jeoffreylim
pushed a commit
to jeoffreylim/vertx-sql-client
that referenced
this pull request
Sep 12, 2019
…clipse-vertx#381) * add support for testing with MariaDB Signed-off-by: Billy Yuan <billy112487983@gmail.com> * do not use null since the datatype will be used for the prepare statement parameters Signed-off-by: Billy Yuan <billy112487983@gmail.com> * skip the test for MariaDB because it does not support automatically rounding for fractional seconds Signed-off-by: Billy Yuan <billy112487983@gmail.com> * add connection URI support for MariaDB Signed-off-by: Billy Yuan <billy112487983@gmail.com> * travis setup Signed-off-by: Billy Yuan <billy112487983@gmail.com> * update documentation Signed-off-by: Billy Yuan <billy112487983@gmail.com> * TestContainers migration for MySQL tests Signed-off-by: Billy Yuan <billy112487983@gmail.com> * use single init SQL script for MySQL Signed-off-by: Billy Yuan <billy112487983@gmail.com> * boost MySQL testing with the shared instance Signed-off-by: Billy Yuan <billy112487983@gmail.com> Signed-off-by: Jeoffrey Lim <jeoffreyl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380