Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliance workflow fails due to new pylint version which checks for W1514 #621

Closed
mlasch opened this issue Aug 24, 2021 · 0 comments · Fixed by #622
Closed

Compliance workflow fails due to new pylint version which checks for W1514 #621

mlasch opened this issue Aug 24, 2021 · 0 comments · Fixed by #622
Labels
bug tests

Comments

@mlasch
Copy link
Contributor

mlasch commented Aug 24, 2021

The CI pipeline fails on Compliance workflow, because the new pylint version has additional checks which fail. New version pylint 2.10 checks for W1514 which is defined in PEP-0597. pylint is used to check the integration tests. Affected version used is pylint-2.10.2-py3-none-any.whl.

integration/conftest.py:75:34: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
integration/conftest.py:89:34: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
integration/conftest.py:104:34: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)

-----------------------------------
Your code has been rated at 9.87/10
mlasch added a commit to mlasch/wakaama that referenced this issue Aug 25, 2021
@mlasch
[eclipse-wakaama#621] Solve pylint W1514 warnings in Compliance workflow
e4275af 
Use UTF-8 encoding in open() calls to comply with PEP-0597
in the integration tests. This will iron out the W1514
(unspecified-encoding) warnings from pylint in the Compliance
workflow.

Signed-off-by: Marc Lasch <marc.lasch@husqvarnagroup.com>
@mlasch mlasch mentioned this issue Aug 25, 2021
Merged
mlasch added a commit that referenced this issue Aug 25, 2021
@mlasch
[#621] Solve pylint W1514 warnings in Compliance workflow
1224b91 
Use UTF-8 encoding in open() calls to comply with PEP-0597
in the integration tests. This will iron out the W1514
(unspecified-encoding) warnings from pylint in the Compliance
workflow.

Signed-off-by: Marc Lasch <marc.lasch@husqvarnagroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#621] Solve pylint W1514 warnings in Compliance workflow mlasch/wakaama
1 participant
@mlasch