CI: Add gitlint #590
Merged
CI: Add gitlint #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The But I guess project can make it mandatory, if wanted anyway. So it's up to you to decide. |
If no longer needed for IP checking, I can not see the benefit of it anymore and will remove the check. |
rettichschnidi
force-pushed
the
gardena/rs/add-gitlint
branch
3 times, most recently
from
00852c7
to
e794c6c
Compare
Closed
rettichschnidi
force-pushed
the
gardena/rs/add-gitlint
branch
from
e794c6c
to
cfd75f8
Compare
This is a fairly default configuration, which, among other stuff, checks for the subject line being 72 or less characters as required by the Eclipse project handbook. Non-default rules: - Enforce at least 20 characters in the commit body - Disallow the word "fixup" in the title messages. Intended to prevent accidents like d31d026. In case any of those rules get in the way, use the "gitlint-ignore" tag in the commit message to suppress gitlint findings for this specific commit. To configure a rule permanently, adapt .gitlint. The GitHub Action runs only on PRs, not after each push. The idea is to prevent annoyance when working on code, using WIP or other non-compliant commit messages.
rettichschnidi
force-pushed
the
gardena/rs/add-gitlint
branch
from
cfd75f8
to
bd996b6
Compare
This was referenced Apr 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly default configuration, which, among other stuff, checks for the subject line being 72 or less characters is required by the Eclipse project handbook.
Non-default rules:
In case any of those rules get in the way, use the "gitlint-ignore" tag in the commit message to suppress gitlint findings for this specific commit. To configure a rule permanently, adapt .gitlint.
The GitHub Action runs only on PRs, not after each push. The idea is to prevent annoyance when working on code, using WIP or other non-compliant commit messages.
Ideas to test this PR locally:
tools/ci/run_ci.sh --run-gitlinton ittools/ci/run_ci.sh --run-gitlint --branch-source HEAD --branch-target HEAD~100