Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In XML file with Windows EOL (CR LF) the togle line comment command adds incorrect closing tag #909

Closed
mplukas opened this issue Oct 19, 2022 · 0 comments

Comments

@mplukas
Copy link

mplukas commented Oct 19, 2022

In XML file if a line ends with Windows end of line characters (CR LF), toggling comment on this line adds incorrect closing tag.
For example the line (ending with CR LF )

<a>

is changed to

<!--<a>
--

Observed in versions 0.15.0, 0.15.1.

vrubezhny added a commit to vrubezhny/tm4e that referenced this issue Oct 27, 2022
…t defined

The Text Selection is preserved as much as possible after the toggle line comment action when
language configuration defines only block comment (so it's used instead of line comments)

Also fixes: eclipse-wildwebdeveloper/wildwebdeveloper#909
vrubezhny added a commit to vrubezhny/tm4e that referenced this issue Oct 27, 2022
…t defined

The Text Selection is preserved as much as possible after the toggle line comment action when
language configuration defines only block comment (so it's used instead of line comments)

Also fixes: eclipse-wildwebdeveloper/wildwebdeveloper#909
vrubezhny added a commit to vrubezhny/tm4e that referenced this issue Oct 28, 2022
…t defined

The Text Selection is preserved as much as possible after the toggle line comment action when
language configuration defines only block comment (so it's used instead of line comments)

Also fixes: eclipse-wildwebdeveloper/wildwebdeveloper#909
vrubezhny added a commit to vrubezhny/tm4e that referenced this issue Oct 31, 2022
…t defined

The Text Selection is preserved as much as possible after the toggle line comment action when
language configuration defines only block comment (so it's used instead of line comments)

Also fixes: eclipse-wildwebdeveloper/wildwebdeveloper#909
vrubezhny added a commit to vrubezhny/tm4e that referenced this issue Dec 5, 2022
…t defined

The Text Selection is preserved as much as possible after the toggle line comment action when
language configuration defines only block comment (so it's used instead of line comments)

Also fixes: eclipse-wildwebdeveloper/wildwebdeveloper#909
mickaelistria pushed a commit to eclipse-tm4e/tm4e that referenced this issue Dec 7, 2022
…t defined

The Text Selection is preserved as much as possible after the toggle line comment action when
language configuration defines only block comment (so it's used instead of line comments)

Also fixes: eclipse-wildwebdeveloper/wildwebdeveloper#909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants