Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transport/rx unused-variable warnings #240

Closed

Conversation

PetervdPerk-NXP
Copy link
Contributor

I'm compiling with werror thus the unused zbuf variable come up as an errror.
Since they aren't used I'm just calling _z_zbuf_view

@p-avital
Copy link
Contributor

Hi,
Thanks for the fix :)
However, these line will conflict with the massive PR that's coming for the new protocol, so we won't merge it. I'm keeping the PR open as a reminder to fix that on the new-protocol branch, although I think I already did :)

@PetervdPerk-NXP
Copy link
Contributor Author

@p-avital what would be the schedule for this ''new protocol" PR?

@p-avital
Copy link
Contributor

@PetervdPerk-NXP most likely, we'll merge it into main near the start of September.

@p-avital
Copy link
Contributor

Hi @PetervdPerk-NXP ,
Just notifying you that the large new-protocol PR has been merged. Like I said earlier, I'm fairly certain your issue is now fixed. If not, feel free to make a new PR :)

@p-avital p-avital closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants