Add raweth transport (glue) #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-roland
force-pushed
the
ft_raweth_transport
branch
from
f1448e5
to
e899531
Compare
|
LGTM but before approving/merging I'd like to see some tests added to this PR. |
|
Added a CI test in build-check workflow + applied fix from #289 |
Mallets
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the follow up of #283 and adds the code binding the new transport to the rest of zenoh-pico.
Might sneak in some tasks code reuse for multicast and raweth if useful.
Edit: Ok so it was interesting to reuse the lease and transport create/close code as they were large and very similar. The adjustments that had to be done include: