Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recopy key instead of steal when undeclaring #305

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jean-roland
Copy link
Contributor

This fixes #282, the undeclare process for queryable and subscription was:

1) steal the keyexpr
2) send the declare N message
3) remove subscription/queryable from session

The delay between 1) and 3) was the source of the problem and stealing the keyepr was probably useful before the introduction of refcounting for subscriptions and queryables, but it is no longer necessary.

@Mallets Mallets merged commit ee4db79 into eclipse-zenoh:master Jan 8, 2024
46 checks passed
@jean-roland jean-roland deleted the fix_key_steal branch January 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault occurs when receiving messages while undeclaring subscriber [Bug]
2 participants