Attachment support for pub/sub #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: build tests only in c11 * fix: remove c11 macros from examples * feat: add a way to force c99 standard * ci: add a c99 compilation test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@jean-roland can I have a review? :D |
cguimaraes
reviewed
Jan 16, 2024
|
LGTM but since we are in a modularization effort in Zenoh-Pico, I believe there should be a |
|
Now this is only the first phase of attachments so that'll do, but for the final one we'd need a CI test checking that both configuration works and an attachment update on ** Approved ** |
Mallets
reviewed
Jan 18, 2024
Mallets
reviewed
Jan 18, 2024
Mallets
approved these changes
Jan 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need pub/sub attachments earlier, and they're easier to implement, we merge them before enabling attachments in query/replies.
This PR also paves the way for query/replies attachment support, but their API still needs some work to ensure ownership stays clear.