Update encoding format on the wire #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mallets could you review this PR? |
Mallets
reviewed
Apr 11, 2024
src/protocol/codec.c
Outdated
| } | ||
|
|
||
| int8_t _z_encoding_encode(_z_wbuf_t *wbf, const _z_encoding_t *en) { | ||
| _Bool has_suffix = _z_bytes_check(en->suffix); |
There was a problem hiding this comment.
For naming alignment, it should be called has_schema and en->schema.
Mallets
reviewed
Apr 11, 2024
tests/z_msgcodec_test.c
Outdated
| val.encoding.prefix = gen_zint(); | ||
| _z_encoding_t gen_encoding(void) { | ||
| _z_encoding_t en; | ||
| en.prefix = gen_uint32() & 0x7fffffff; |
There was a problem hiding this comment.
Prefix should be represented as an uint16_t.
|
Definition of typedef struct {
_z_bytes_t suffix;
z_encoding_prefix_t prefix;
} _z_encoding_t;It should become: typedef struct {
_z_bytes_t schema;
uint16_t id;
} _z_encoding_t;
|
Mallets
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
encoding_tprefix is sent on the wire changed to be 31bits + suffix flag. Suffix is only written when present.Because of misalignment on interest format with Zenoh, interests are deactivated by default for now.
In addition, MSVC warning
C4127: conditional statement is constant, has been disabled as it caused Windows build to fail following the addition of pull subscriber handlers.