Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim long marker properties #1295

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Trim long marker properties #1295

merged 1 commit into from
Jan 31, 2024

Conversation

donat
Copy link
Contributor

@donat donat commented Jan 29, 2024

Fixes #1294

@donat donat added this to the 3.1.10 milestone Jan 29, 2024
jdneo
jdneo approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I built a Buildship locally with this change and not observe the marker property too long error on a project which has that error before.

@donat donat requested a review from reinsch82 January 31, 2024 12:38
reinsch82
reinsch82 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@reinsch82 reinsch82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
good catch on the string length vs byte array length!

@donat
Copy link
Contributor Author

donat commented Jan 31, 2024

I merely followed the pattern from https://github.com/eclipse-platform/eclipse.platform/blob/97d555a8b563dcb3a32bd43ad58ba452fa027a73/resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/MarkerInfo.java#L56-L60. Anyway, thanks!

@donat donat merged commit 420e3a0 into master Jan 31, 2024
4 checks passed
@donat donat deleted the donat/long-marker-property branch January 31, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

@reinsch82 reinsch82 reinsch82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.10
Development

Successfully merging this pull request may close these issues.

Marker Property value is too long
3 participants
@donat @reinsch82 @jdneo