Provide syntax highlighting in the compare editor #684 #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables syntax highlighting for build scripts (Groovy and Kotlin DSL) in these areas: * Compare editor * Dialog: Restore from Local History * Opening an old file revision from history
|
I've tested and reviewed your changes. LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #684
This enables syntax highlighting for build scripts (Groovy and Kotlin DSL) in these areas:
(1) For build scripts in Kotlin DSL (Generic Editor) also this fix already released with Eclipse 2024-06 is needed: eclipse-platform/eclipse.platform.ui#1880. In older Eclipse versions a
NullPointerExceptionwill be thrown.(2) For build scripts in Kotlin DSL (Generic Editor) also this fix already released with Eclipse 2024-06 is needed: eclipse-platform/eclipse.platform.ui#1873. In older Eclipse versions the content type determination will not work and the file is opened without syntax highlighting.