Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new preference to insert whitespace before closing empty end-tag #197

Closed
fbricon opened this issue Nov 5, 2018 · 0 comments · Fixed by #224
Closed

Add new preference to insert whitespace before closing empty end-tag #197

fbricon opened this issue Nov 5, 2018 · 0 comments · Fixed by #224
Assignees
@NikolasKomonen
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Milestone
v0.3.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 5, 2018

... so that, if enabled:

<br/> -> <br />
<foo attribute="bar"/> -> <foo attribute="bar" />

if disabled:

<br /> -> <br/>
<foo attribute="bar" /> -> <foo attribute="bar"/>

Current behaviour is equivalent to having this option enabled
@fbricon fbricon added enhancement New feature or request formatting This issue or enhancement is related to formatting support labels Nov 5, 2018
@fbricon fbricon added this to the v0.0.3 milestone Nov 5, 2018
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 8, 2018
@NikolasKomonen
Handles setting a space before a self closing tag end bracket.
5e60ac9 
Fixes eclipse-lemminx#197

Also fixed an unknown issue where the new settings would replace existing and not
update the current ones. In the case of a setting not being sent from the client,
the default value set on the server side would be lost in XMLFormattingOptions
anymore.

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 14, 2018
@NikolasKomonen
Handles setting a space before a self closing tag end bracket.
aed15df 
Fixes eclipse-lemminx#197

Also fixed an unknown issue where the new settings would replace existing and not
update the current ones. In the case of a setting not being sent from the client,
the default value set on the server side would be lost in XMLFormattingOptions
anymore.

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen mentioned this issue Nov 14, 2018
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 14, 2018
@NikolasKomonen
Handles setting a space before a self closing tag end bracket.
06d9a34 
Fixes eclipse-lemminx#197

Also fixed an unknown issue where the new settings would replace existing and not
update the current ones. In the case of a setting not being sent from the client,
the default value set on the server side would be lost in XMLFormattingOptions
anymore.

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 14, 2018
@NikolasKomonen
Handles setting a space before a self closing tag end bracket.
86644a6 
Fixes eclipse-lemminx#197

Also fixed an unknown issue where the new settings would replace existing and not
update the current ones. In the case of a setting not being sent from the client,
the default value set on the server side would be lost in XMLFormattingOptions
anymore.

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
fbricon pushed a commit that referenced this issue Nov 14, 2018
@NikolasKomonen @fbricon
Handles setting a space before a self closing tag end bracket.
b3b16e8 
Fixes #197

Also fixed an unknown issue where the new settings would replace existing and not
update the current ones. In the case of a setting not being sent from the client,
the default value set on the server side would be lost in XMLFormattingOptions
anymore.

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Handles setting a space before a self closing tag end bracket. NikolasKomonen/lsp4xml
2 participants
@fbricon @NikolasKomonen