Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax NG schema validation not working when DOCTYPE declaration missing #1393

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Dec 7, 2022

Relax NG schema validation not working when DOCTYPE declaration missing with file association

Fixes redhat-developer/vscode-xml#831

Signed-off-by: azerr azerr@redhat.com

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, just noticed the date on a copyright header was wrong

@angelozerr angelozerr force-pushed the fileassociation-relaxng branch from 386e1b6 to 8af6944 Compare December 8, 2022 13:35
with file association

Fixes redhat-developer/vscode-xml#831

Signed-off-by: azerr <azerr@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Angelo!

@datho7561 datho7561 merged commit 13f2fb4 into eclipse-lemminx:main Dec 8, 2022
@JessicaJHee JessicaJHee modified the milestone: 0.23.0 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax NG schema validation not working when DOCTYPE declaration missing with file association
3 participants