added quarkus.http.root-path property to CodeLensURL

[AlexXuChen]

Added quarkus.http.root-path property from application.properties to CodeLens URL.

Closes redhat-developer/quarkus-ls/issues/368

Signed-off-by: Alexander Chen alchen@redhat.com

*THE CHANGE:

[angelozerr]

At first LSP4MP should be not linked to quarkus, it means that it should not use quarkus.http.root-path in the code. LSP4MP provides a JaxRSContext where you can set some value.

For instance Quarkus provides quarkus.http.port property and if you see the LSP4MP code it doesn't use it. The quarkus.http.port is retrieved from quarkus-ls side and update the JaxRscontext#setServerPort with the proper value of quarkus.http.port:

https://github.com/redhat-developer/quarkus-ls/blob/d931b173582344dad9357a0ecd1180af0984b718/quarkus.jdt.ext/com.redhat.microprofile.jdt.quarkus/src/main/java/com/redhat/microprofile/jdt/internal/quarkus/jaxrs/java/QuarkusJaxRsCodeLensParticipant.java#L48

After that LSP4MP get the serverPort to build the proper local base URL at

lsp4mp/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/commons/MicroProfileJavaCodeLensParams.java

Line 103 in cbcc381

localBaseURL = new StringBuilder("http://localhost:").append(getLocalServerPort()).toString();

You should try to mimic this strategy. At first I will remove getLocalBaseUrl and getServerPort from MicroProfileJavaCodeLensParams

lsp4mp/microprofile.jdt/org.eclipse.lsp4mp.jdt.core/src/main/java/org/eclipse/lsp4mp/commons/MicroProfileJavaCodeLensParams.java

Line 101 in cbcc381

public String getLocalBaseURL() {

because it's parameters (we should not update it) and move those methods in JaxRsContext, the idea is to work with JaxRsContext and not with MicroProfileJavaCodeLensParams to build the URL:

private static void collectURLCodeLenses(IJavaElement[] elements, String rootPath, Collection<CodeLens> lenses,
			JaxRsContext context, IJDTUtils utils, IProgressMonitor monitor)

I will add in JaxRsContext a new field with getter/setter rootPath. QuarkusJaxRsCodeLensParticipant will update this rootPath with quarkus.http.root-path.

The JaxRsContext will use this info to build the URL:

public String getLocalBaseURL() {
   StringBuilder localBaseURL = new StringBuilder("http://localhost:");
  localBaseURL .append(getLocalServerPort()).toString();
   if (rootPath != null) {
      localBaseURL .append(getRootPath());
   }
  return localBaseURL.toString();
}

[angelozerr]

@AlexXuChen this PR doesn't fix all issues from redhat-developer/quarkus-ls/issues/368.

I re-read it and it seems @ApplicationPath Java annotation play the same role than the quarkus property quarkus.http.root-path. As @ApplicationPath is a part of MicroProfile spec; it should be managed on LSP4MP side.

According to @clochardpagan comments:

• there is no option to work with host differing from localhost. That's a problem.
• there is no option to work with https:// at all. Bad, but can be fixed via SSL termination or/and proxy.

To fix this problem an idea is to provide a setting to declare a base URL for that. Or perhaps we could declare an array of baseURL to generate several Codelens URL for serveral server. @fbricon @rgrunber what do you think about that?

@AlexXuChen those issues could be done in an another PRs, but please change your commit which closes the issue 368, because this PR doesn't covers all issues.

[rgrunber]

Could localBaseURL that's used in MicroProfileJavaCodeLensParams be removed ? I don't think it's used anywhere now that JaxRsContext took over the same functionality.

There's also extraneous whitespace throughout the files. Just need to remove them.

[AlexXuChen]

Could localBaseURL that's used in MicroProfileJavaCodeLensParams be removed ? I don't think it's used anywhere now that JaxRsContext took over the same functionality.

Originally MicroProfileJavaCodeLensParams was used before the JaxRsContext was required, and that was the only use of localBaseURL from the params. So yes, I believe it's okay to remove since it is unused.

However, I do believe the original intention was to remove MicroProfileJavaCodeLensParams entirely from the CodeLens participant, however I didn't since it is required to determine if the server is available (stores and sets checkServerAvailable)

[rgrunber]

Yeah, there seems to be a bit of overlap between the MicroProfile params and the JaxRsContext. Maybe there's some parameters that need to reside in params for a little while before they get transfered over to the JaxRsContent but the localBaseURL stood out as the single getter in MicroProfile params wans't being called anywhere after you switched over and looked pretty much the same as the new one in JaxRsContext.

[rgrunber]

I've tried this out (with some modifications on quarkus-ls) and it seems to be working as expected.