Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't implement by default custom language client API #399

Merged
merged 1 commit into from
May 23, 2023

Conversation

angelozerr
Copy link
Contributor

Don't implement by default custom language client API

Fixes #398

@angelozerr angelozerr requested a review from datho7561 May 23, 2023 16:30
Fixes eclipse#398

Signed-off-by: azerr <azerr@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Angelo!

@datho7561
Copy link
Contributor

The tests passed locally for me.

@datho7561 datho7561 merged commit c91e736 into eclipse:master May 23, 2023
@angelozerr
Copy link
Contributor Author

Thanks @datho7561 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't implement by default custom language client API
2 participants