You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are TCK tests that expect system properties to be mutable in MP config. The specification does not state this is a requirement.
ConfigProviderTest.testDynamicValueInPropertyConfigSource()
ConfigProviderTest.testGetPropertyNames()
ConfigProviderTest.testPropertyConfigSource() (as a side effect of properties set during runtime of TCK)
EmptyValuesTest.testEmptyStringProgrammaticLookup()
there should be no requirement for the system properties config source to be mutable
in general mutability of config is dangerous (e.g. if somebody changes 2 values and an application uses both of them, it could get first value from old version and second value from new version of config -> this creates inconsistencies that are really hard to troubleshoot)
The text was updated successfully, but these errors were encountered:
dmlloyd
added
bug 🪲
An error in the implementation code or documentation
clarification 🏆
A clarification (PR) or request for clarification (issue) in the spec or API
and removed
mutable
clarification 🏆
A clarification (PR) or request for clarification (issue) in the spec or API
labels
Mar 4, 2020
As far as I understand the updated specification, it now mandates that Config implementation never caches and must cycle through all config sources to obtain a value.
Although this seems like a major decision about an implementation and a risk (as I mentioned above - if a change happens, we may get data from two change sets), I think this issue can be closed.
There are TCK tests that expect system properties to be mutable in MP config. The specification does not state this is a requirement.
ConfigProviderTest.testDynamicValueInPropertyConfigSource()
ConfigProviderTest.testGetPropertyNames()
ConfigProviderTest.testPropertyConfigSource() (as a side effect of properties set during runtime of TCK)
EmptyValuesTest.testEmptyStringProgrammaticLookup()
The text was updated successfully, but these errors were encountered: