-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect description in the README #457
Comments
Both spec and Javadoc on ConfigProperty annotation mentions the retrieval of the dynamic config property.
We left how the runtime handles the dynamism unspeced on purpose. |
I'd missed that reference in searching yesterday. Not sure if there are other issues related to this, but I think the spec needs to move away from leaving it undefined otherwise it becomes a huge gray area where implementations can do completely different things and users get unexpected behavior if they migrate between them |
Thanks for your feedback, Ken! Points taken. Let's add a couple of sentences in the spec to clearly spell it out. |
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
Since we have not reached a conclusion, I'll move this issue out of the MP Config 1.4 milestone. |
* #457 add a section to make dynamic config source more visible Signed-off-by: Emily Jiang <emijiang6@googlemail.com> * #457 address review comments Signed-off-by: Emily Jiang <emijiang6@googlemail.com> * update format and fix typo Signed-off-by: Emily Jiang <emijiang6@googlemail.com> * tidy up Signed-off-by: Emily Jiang <emijiang6@googlemail.com> * address comments Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
fixed by #478 |
The project README has the following statement in the third paragraph:
As the current specification doesn't describe the ability to handle dynamically changing values, it is probably a good idea to remove this statement.
The text was updated successfully, but these errors were encountered: