#333 javadoc clarification on ConfigSource #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
|
@dmlloyd please review |
dmlloyd
reviewed
Jan 17, 2020
| @@ -84,7 +84,8 @@ | |||
| Map<String, String> getProperties(); | |||
|
|
|||
| /** | |||
| * Gets all property names known to this config source, without evaluating the values. | |||
| * Gets all property names known to this config source, without evaluating the values. | |||
| * The returned property names may be a subset of the configurations in this config source, due to security or performance reasons. | |||
There was a problem hiding this comment.
Suggested change
| * The returned property names may be a subset of the configurations in this config source, due to security or performance reasons. | |
| * The returned property names may be a subset of the names of the total set of retrievable properties in this config source. |
I don't think we want to constrain the purposes for which the names can be a subset.
There was a problem hiding this comment.
ok. @dmlloyd I have updated the javadoc as you recommended. Please check.
…333-configsource-javadoc
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
kenfinnigan
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emily Jiang emijiang6@googlemail.com