Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken Java 8 GH action build #626

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Azquelt
Copy link
Member

@Azquelt Azquelt commented Apr 18, 2024

The newest version of maven does not work with Java 8. The jenkins build uses an older version of maven, but github actions have no intention of allowing the confiugration of the maven version actions/setup-java#457

The newest version of maven does not work with Java 8. The jenkins build uses an older version of maven, but github actions have no intention of allowing the confiugration of the maven version actions/setup-java#457
@Azquelt
Copy link
Member Author

Azquelt commented Apr 18, 2024

I would like to merge this because having the Java 8 build always failing means that no other github actions checks run for pull requests.

The Jenkins build will still cover building with Java 8.

@Azquelt Azquelt changed the title Remove Java 8 GH action build Remove broken Java 8 GH action build Apr 18, 2024
@Emily-Jiang Emily-Jiang self-requested a review April 18, 2024 12:38
Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Azquelt Azquelt merged commit 298dd53 into main Apr 18, 2024
7 checks passed
@Azquelt Azquelt deleted the Azquelt-disable-java8-action-build branch April 18, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants