Add missing proxy property to docstring #756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issues #461.
It's been quite some time since the issue was created and things might have changed.
While attempting to replicate the silent failure (mentioned by the issue creator), I received an informative error message from the
PySocks
package (socks.ProxyConnectionError: Error connecting to HTTP proxy example-proxy.com:8080: timed out
).To get the above error I just extended the basic publish example to include the proxy_args dictionary, including only the required keys.
The fact that I received an error for port 8080 raised a flag of a default value, which is the case.
PySocks has a DEFAULT_PORTS dictionary.
I extended the docstring, adding the port as optional.