Fix grammar, typos #788
Merged
Fix grammar, typos #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2024
Closed
Closes eclipse#614 Co-authored-by: alexander-minchin <83529885+alexander-minchin@users.noreply.github.com> Signed-off-by: Aarni Koskela <akx@iki.fi>
Co-authored-by: jalotra <shivam.jalotra@flipkart.com> Signed-off-by: Aarni Koskela <akx@iki.fi>
|
Thank. But I've an issue regarding Eclipse requirement with this PR: since some change are authored by @alexander-minchin which don't seems to have signed the ECA (https://accounts.eclipse.org/user/eca) I'm not sure I'm allowed to merge it. @alexander-minchin could you complete the ECA signing (https://accounts.eclipse.org/user/eca) with the email you used for the commit (it's the github email: 83529885+alexander-minchin AT users.noreply.github DOT com) |
|
Since the change is rather small, I think it's okay to merge it even if first author didn't fully complete the ECA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #614 (includes changes from it, plus some reformatting).
Closes #660 (includes changes from it, including a missing
userdata_set).