Fix type annotations #828
Merged
Fix type annotations #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanPlasse
force-pushed
the
fix-type-annotations
branch
2 times, most recently
from
7dbfcd3
to
2ef2005
Compare
JonathanPlasse
force-pushed
the
fix-type-annotations
branch
from
2ef2005
to
ea6a952
Compare
|
thank for those fixes. Could you sign the ECA (https://accounts.eclipse.org/user/eca) so I can merge your contribution ? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for updating and modernizing paho-mqtt.
I am a maintainer of aiomqtt, a wrapper around paho-mqtt.
When migrating to paho-mqtt 2.0, we encountered some type regressions as we were using types-paho-mqtt.
This PR fix all the types errors on aiomqtt.