-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv4 support for RIOT OS #129
Conversation
Edit: sorry, I was wrong, it's just the PR you depend on, which needs the ECA. |
Is that common in RIOT, to select IPv4 or IPv6 at compile time? |
Yes, RIOTs sock abstraction for instance will provide the IPv6 member conditionally at compile time, with all of its implications. At the moment the IPv4 member will be always present, so checking for |
I'm not sure, if I get it. It sounds, that IPv6 must be enabled at compile time, but the other sentence seems to indicate, that IPv4 is always usable. So, the configurations are:
Or am I mislead? |
I had a closer look on the codebase. As far as I can tell all important parts that would require IPv4 are left out conditionally by the compile-time switch So in summary we have all possible configurations:
|
|
Looks good, ready to merge right after doing PR #127. |
b2ca395
to
4cb2832
Compare
Rebased :) (Sorry for force-pushing multiple times, I tried to use another email address of mine, but ECA failed with it) |
LGTM |
merged to develop, cherry picked to main. |
Add the capability to communicate using IPv4.
PR in RIOT OS has already been approved and was merged:
Dependencies:
I'll rebase once the dependencies are merged.
Off-topic:
At first glance the project seemed to be stale, but after looking into the develop branch it became clear it is not. I just wanted to point out that some first-time users (like me) might get the wrong impression when they see that the latest commit to master is from July 2020 ;)