Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Toggle Block Comment" handler should fail back to "Toggle Lines comment" if there are no block comment #450

Closed
mickaelistria opened this issue Oct 8, 2022 · 3 comments
Closed

"Toggle Block Comment" handler should fail back to "Toggle Lines comment" if there are no block comment #450

mickaelistria opened this issue Oct 8, 2022 · 3 comments
Assignees
@vrubezhny

Comments

@mickaelistria
Copy link
Contributor

"Toggle Block Comment" handler should fail back to "Toggle Lines comment" if there are no block comment.
The goal is to have Ctrl+Shift+/ working in XML editor (whose language-configuration doesn't define block comment).
@mickaelistria
Copy link
Contributor Author

@vrubezhny Please have a look if you are available to do so soon (no need to shamble other pending tasks,this one can wait if necessary)

vrubezhny added a commit to vrubezhny/tm4e that referenced this issue Oct 31, 2022
@vrubezhny
"Toggle Block Comment" handler should fail back to "Toggle Lines comm…
2704356 
…ent" if there are no block comment eclipse#450
mickaelistria pushed a commit that referenced this issue Nov 1, 2022
@vrubezhny @mickaelistria
"Toggle Block Comment" handler should fail back to "Toggle Lines comm…
adbfa82 
…ent" if there are no block comment #450
@sebthom
Copy link
Member

sebthom commented Nov 3, 2022

@mickaelistria is this issue fully resolved by #463 ?

@mickaelistria
Copy link
Contributor Author

Should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebthom @mickaelistria @vrubezhny