Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: licensecheck fails to validate project maven modules #523

Merged
merged 1 commit into from
Apr 27, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 48 additions & 9 deletions .github/workflows/licensecheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,27 @@ name: License check

on:
push:
branches:
- '*'
branches: # build all branches
- '**'
tags-ignore: # but don't build tags
- '**'
pull_request:
branches:
- '*'
branches:
- '**'
workflow_dispatch:
# https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

defaults:
run:
shell: bash

env:
JAVA_VERSION: 17

jobs:
build:

build:
runs-on: ubuntu-latest

steps:
- name: Git Checkout
uses: actions/checkout@v3 #https://github.com/actions/checkout
Expand All @@ -36,8 +44,13 @@ jobs:
restore-keys: |
${{ runner.os }}-mvnrepo-

- name: License check
run: |
- name: "Install: Maven"
uses: stCarolas/setup-maven@v4.5 # https://github.com/stCarolas/setup-maven
with:
maven-version: 3.9.1

- name: License check # see https://github.com/eclipse/dash-licenses
run: |
set -eu

MAVEN_OPTS="${MAVEN_OPTS:-}"
Expand All @@ -48,6 +61,21 @@ jobs:
echo " -> MAVEN_OPTS: $MAVEN_OPTS"
export MAVEN_OPTS

# "excludeArtifactIds" parameter is to prevent builds from failing with:
# License information could not be automatically verified for the following content:
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.core/0.5.2-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.feature/0.5.4-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.language_pack.feature/0.1.1-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.language_pack/0.1.1-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.languageconfiguration/0.5.4-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.markdown/0.5.1-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.registry/0.6.3-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.samples/0.4.1-SNAPSHOT
# maven/mavencentral/org.eclipse/org.eclipse.tm4e.ui/0.6.2-SNAPSHOT
# p2/orbit/p2.eclipse.plugin/org.eclipse.ui.tests.harness/1.9.0.v20221024-2137
# This content is either not correctly mapped by the system, or requires review.
# Error: Dependency license check failed. Some dependencies need to be vetted.

mvn \
--errors \
--update-snapshots \
Expand All @@ -56,4 +84,15 @@ jobs:
--no-transfer-progress \
org.eclipse.dash:license-tool-plugin:license-check \
--file pom.xml \
-Ddash.fail=true
-Ddash.fail=true \
-DexcludeArtifactIds=\
org.eclipse.tm4e.core,\
org.eclipse.tm4e.feature,\
org.eclipse.tm4e.language_pack.feature,\
org.eclipse.tm4e.language_pack,\
org.eclipse.tm4e.languageconfiguration,\
org.eclipse.tm4e.markdown,\
org.eclipse.tm4e.registry,\
org.eclipse.tm4e.samples,\
org.eclipse.tm4e.ui,\
org.eclipse.ui.tests.harness