-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Task Tag UI preferences #528
Conversation
@rubenporras can you please give this a try |
06d7ba1
to
f443e79
Compare
33a4b1c
to
bc854e4
Compare
@sebthom , thanks for doing the UI config backed by preferences. If you do not mind, I would do some testing after it is merged using the snapshot that will be built afterwards, that is a bit easier for me. |
I still have some trouble understanding the differentiation between Task and Problem. I think that a single category (Task) with three priorities is simpler and more understandable, and also enough, as in the JDT: I would also change the text of the dialog for one more descriptive, like the one in the screenshot. I also tested the JDT again, and even for prio high the icon is not the one of an error marker, which is what I would expect as well. |
@rubenporras I changed the text in the dialog. Problem markers appear in the problems view and are annotated on the icons in the project explorer. |
Thanks. I understand that now. It still feels to me that having just task markers is the best thing, and reserve problem makers for the language server (be it compiler, code analyzer, etc.). The second best option to me would be to have the default to just use tasks and leave problems for power users that really want to have that. This is based on my personal preference, but also in the experience of using JDT and other tools, so far I do not know about any that show error markers for comments. |
I tested today on the released TM4E, and it does not seem to work, I have comments such us (we use -- as single line comment separator) |
@rubenporras #532 should solve it. |
This PR adds the ability to add,remove,configure task tags per workspace via preferences: