Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Task Tag UI preferences #528

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented May 5, 2023

This PR adds the ability to add,remove,configure task tags per workspace via preferences:

image

@sebthom
Copy link
Member Author

sebthom commented May 5, 2023

@rubenporras can you please give this a try

@sebthom sebthom force-pushed the textmarkers-ui branch 2 times, most recently from 06d7ba1 to f443e79 Compare May 5, 2023 18:51
@sebthom sebthom force-pushed the textmarkers-ui branch 2 times, most recently from 33a4b1c to bc854e4 Compare May 7, 2023 14:47
@rubenporras
Copy link
Contributor

@sebthom , thanks for doing the UI config backed by preferences. If you do not mind, I would do some testing after it is merged using the snapshot that will be built afterwards, that is a bit easier for me.

@rubenporras
Copy link
Contributor

I still have some trouble understanding the differentiation between Task and Problem. I think that a single category (Task) with three priorities is simpler and more understandable, and also enough, as in the JDT:

image

I would also change the text of the dialog for one more descriptive, like the one in the screenshot.

I also tested the JDT again, and even for prio high the icon is not the one of an error marker, which is what I would expect as well.

@sebthom
Copy link
Member Author

sebthom commented May 8, 2023

@rubenporras I changed the text in the dialog.

Problem markers appear in the problems view and are annotated on the icons in the project explorer.

@rubenporras
Copy link
Contributor

Thanks. I understand that now. It still feels to me that having just task markers is the best thing, and reserve problem makers for the language server (be it compiler, code analyzer, etc.).

The second best option to me would be to have the default to just use tasks and leave problems for power users that really want to have that.

This is based on my personal preference, but also in the experience of using JDT and other tools, so far I do not know about any that show error markers for comments.

@sebthom sebthom merged commit 75adb76 into eclipse:main May 8, 2023
@sebthom sebthom deleted the textmarkers-ui branch May 8, 2023 14:19
@rubenporras
Copy link
Contributor

I tested today on the released TM4E, and it does not seem to work, I have comments such us (we use -- as single line comment separator)
-- BUG 123
-- TODO this and that
and I can see that the matcher org.eclipse.tm4e.ui.internal.utils.MarkerUtils.updateTextMarkers(TMDocumentModel, int).matcher on line 135 does not find anything when commentText contains"BUT 123" or "TODO this and that".
The MARKERCONFIG_BY_TAG contains the default tags (BUG, TODO...) so I am not sure what is happening.

@sebthom
Copy link
Member Author

sebthom commented May 15, 2023

@rubenporras #532 should solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants