Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#525): disable broken markdown.math grammars #529

Merged
merged 1 commit into from
May 7, 2023

Conversation

jensli
Copy link
Contributor

@jensli jensli commented May 6, 2023

No description provided.

@sebthom sebthom changed the title fix #525: disable broken markdown.math grammars fix: disable broken markdown.math grammars (#525) May 6, 2023
@github-actions github-actions bot added the bug label May 6, 2023
@jensli
Copy link
Contributor Author

jensli commented May 6, 2023

@sebthom Should the commit message also have issue ID at the end instead of at the begging?

@jensli jensli force-pushed the disable-markdown-math branch 2 times, most recently from 5fc346f to 9b28ed4 Compare May 6, 2023 19:15
@sebthom
Copy link
Member

sebthom commented May 6, 2023

@sebthom Should the commit message also have issue ID at the end instead of at the begging?

just the PR is sufficient

@jensli
Copy link
Contributor Author

jensli commented May 7, 2023

I updated versions from 0.1.1 to 0.2.0. That seems appropriate because behaviour has changed.

@jensli jensli requested a review from jabby May 7, 2023 10:31
@jensli
Copy link
Contributor Author

jensli commented May 7, 2023

Build is now successful. I think this can be merged.

@sebthom sebthom changed the title fix: disable broken markdown.math grammars (#525) fix(#525): disable broken markdown.math grammars May 7, 2023
@sebthom sebthom merged commit 18507fa into eclipse:main May 7, 2023
@sebthom
Copy link
Member

sebthom commented May 7, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants