Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR DOMException in browser console #2166

Closed
dimpon opened this issue Jul 21, 2023 · 1 comment · Fixed by #2167
Closed

ERROR DOMException in browser console #2166

dimpon opened this issue Jul 21, 2023 · 1 comment · Fixed by #2167
Assignees
Milestone

Comments

@dimpon
Copy link

dimpon commented Jul 21, 2023

Describe the bug

Angular 15 + jsonforms 3.1.0
When a page with form is opened error appears in chrome console.
Reproduced only if showUnfocusedDescription: true and for fields with type: number | integer.

In Chrome, Edge: ERROR DOMException: Failed to execute 'setAttribute' on 'Element': '||' is not a valid attribute name.
In Firefox: ERROR DOMException: String contains an invalid character

Pet app for reproducing.
https://github.com/dimpon/angular-with-jsonforms

Expected behavior

No errors in the console

Steps to reproduce the issue

  1. Build and run pet app https://github.com/dimpon/angular-with-jsonforms
  2. Open in browser
  3. See error in the console

Screenshots

No response

In which browser are you experiencing the issue?

Chrome Version 114.0.5735.199 (Official Build) (64-bit)

Which Version of JSON Forms are you using?

v3.1.0

Framework

Angular

RendererSet

Material

Additional context

No response

lucas-koehler added a commit that referenced this issue Jul 27, 2023
The template had a bug closing the ngIf that checks whether the description
is shown too early. This lead to a DOMException and the description to never be shown.

Fix #2166
@lucas-koehler
Copy link
Contributor

Hi @dimpon ,

thanks for the report ❤️ . I could reproduce this also with Angular 12. This was in fact caused by an incorrect placement of a " in the number renderer. I opened a PR for this.
Note that we don't support Angular 15, yet. So you might run into other issues that are not bugs. See #2085.

@lucas-koehler lucas-koehler added this to the 3.2 milestone Jul 27, 2023
@lucas-koehler lucas-koehler self-assigned this Jul 27, 2023
lucas-koehler added a commit that referenced this issue Jul 27, 2023
The template had a bug closing the ngIf that checks whether the description
is shown too early. This lead to a DOMException and the description to never be shown.

Fix #2166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants