Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect code around markRaw invocation #2379

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

kchobantonov
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 4215a6f
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66f9f1cdbb5e530008085558
😎 Deploy Preview https://deploy-preview-2379--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kchobantonov
Copy link
Contributor Author

@sdirix can you please review

@coveralls
Copy link

Coverage Status

coverage: 81.733%. remained the same
when pulling 4215a6f on kchobantonov:fix-markRaw
into 8c4b2f0 on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit d7f34b9 into eclipsesource:master Sep 30, 2024
8 checks passed
@sdirix sdirix added this to the 3.4.1 milestone Sep 30, 2024
@sdirix sdirix added the vue label Sep 30, 2024
@kchobantonov kchobantonov deleted the fix-markRaw branch December 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants