Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-vuetify: Extract control entries and fix usage instructions #2380

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

lucas-koehler
Copy link
Contributor

fix #2378

The registry entries for the renderers were configured in the same files as the renderers. This lead to the entries being removed due to tree shaking during production builds using esbuild (as used by Vite).

This extracts all entries to separate files and improves the README to no longer import the renderers asynchronously .

fix #2378

The registry entries for the renderers were configured in the same files
as the renderers. This lead to the entries being removed due to tree shaking
during production builds using esbuild (as used by Vite).

This extracts all entries to separate files and improves the README to no
longer import the renderers asynchronously .
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 1b9a392
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6706b0261ee7a40008a0bd09
😎 Deploy Preview https://deploy-preview-2380--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler lucas-koehler requested a review from sdirix October 9, 2024 16:38
@coveralls
Copy link

Coverage Status

coverage: 81.733%. remained the same
when pulling 1b9a392 on lk/2378-fix-vuetify-build
into d7f34b9 on master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I did not test locally

@lucas-koehler lucas-koehler merged commit d6293f3 into master Oct 18, 2024
11 checks passed
@lucas-koehler lucas-koehler deleted the lk/2378-fix-vuetify-build branch October 18, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue Vuetify Forms not rendered after update to 3.4.0, but only in release builds
3 participants