Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes createDefaultValue doesn't follow anyOf, oneOf, allOf #2401 #2402

Merged
merged 7 commits into from
Dec 6, 2024
Merged

fixes createDefaultValue doesn't follow anyOf, oneOf, allOf #2401 #2402

merged 7 commits into from
Dec 6, 2024

Conversation

kchobantonov
Copy link
Contributor

@kchobantonov kchobantonov commented Dec 1, 2024 •
edited
Loading

fixing issue #2401

@netlify Netlify
Copy link

netlify bot commented Dec 1, 2024 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 86bccc0
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6753085f08e68f0008d5d0e9
😎 Deploy Preview https://deploy-preview-2402--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kchobantonov
Copy link
Contributor Author

@sdirix check the fixed example here https://deploy-preview-2402--jsonforms-examples.netlify.app/react-material/#anyOf

sdirix
sdirix requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdirix check the fixed example here https://deploy-preview-2402--jsonforms-examples.netlify.app/react-material/#anyOf

I don't see any difference in the example between master and this PR

packages/core/src/mappers/renderer.ts Outdated Show resolved Hide resolved
packages/core/src/mappers/renderer.ts Outdated Show resolved Hide resolved
@kchobantonov
Copy link
Contributor Author

@sdirix check the fixed example here https://deploy-preview-2402--jsonforms-examples.netlify.app/react-material/#anyOf

I don't see any difference in the example between master and this PR

this is how it looks without the fix

image

and this is how it looks with the fix

image

@kchobantonov kchobantonov requested a review from sdirix December 5, 2024 17:06
@kchobantonov
Copy link
Contributor Author

@sdirix please review again

@kchobantonov kchobantonov requested a review from sdirix December 5, 2024 18:57
@coveralls
Copy link

Coverage Status

coverage: 82.254% (+0.2%) from 82.089%
when pulling 86bccc0 on kchobantonov:fix-createDefaultValue
into 4a4e2ec on eclipsesource:master.

@sdirix sdirix merged commit 576d9e0 into eclipsesource:master Dec 6, 2024
8 checks passed
@sdirix sdirix linked an issue Dec 6, 2024 that may be closed by this pull request
createDefaultValue doesn't follow anyOf, oneOf, allOf #2401
Closed
@sdirix sdirix mentioned this pull request Dec 6, 2024
Closed
@kchobantonov kchobantonov deleted the fix-createDefaultValue branch December 6, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createDefaultValue doesn't follow anyOf, oneOf, allOf
3 participants
@kchobantonov @coveralls @sdirix