Upload command always visible on browser (eclipse-theia#11756)

Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>

Signed-off-by: Federico Bozzini <federico.bozzini@gmail.com>

packages/filesystem/src/browser/filesystem-frontend-contribution.ts

@@ -121,12 +121,19 @@ export class FileSystemFrontendContribution implements FrontendApplicationContri
     }
 
     registerCommands(commands: CommandRegistry): void {
-        commands.registerCommand(FileSystemCommands.UPLOAD, new FileSelection.CommandHandler(this.selectionService, {
-            multi: false,
-            isEnabled: selection => this.canUpload(selection),
-            isVisible: selection => this.canUpload(selection),
-            execute: selection => this.upload(selection)
-        }));
+        commands.registerCommand(FileSystemCommands.UPLOAD, {
+            isEnabled: (...args: unknown[]) => {
+                const selection = this.getSelection(...args);
+                return !!selection && this.canUpload(selection);
+            },
+            isVisible: () => !environment.electron.is(),
+            execute: (...args: unknown[]) => {
+                const selection = this.getSelection(...args);
+                if (selection) {
+                    return this.upload(selection);
+                }
+            }
+        });
     }
 
     protected canUpload({ fileStat }: FileSelection): boolean {
@@ -148,6 +155,15 @@ export class FileSystemFrontendContribution implements FrontendApplicationContri
         }
     }
 
+    protected getSelection(...args: unknown[]): FileSelection | undefined {
+        const { selection } = this.selectionService;
+        return this.toSelection(args[0]) ?? (Array.isArray(selection) ? selection.find(FileSelection.is) : this.toSelection(selection));
+    };
+
+    protected toSelection(arg: unknown): FileSelection | undefined {
+        return FileSelection.is(arg) ? arg : undefined;
+    }
+
     protected pendingOperation = Promise.resolve();
     protected run(operation: () => MaybePromise<void>): Promise<void> {
         return this.pendingOperation = this.pendingOperation.then(async () => {