Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] support AuthenticationForceNewSessionOptions #84

Closed
wants to merge 1 commit into from
Closed

[vscode] support AuthenticationForceNewSessionOptions #84

wants to merge 1 commit into from

Conversation

rschnekenbu
Copy link

What it does

Support of AuthenticationForceNewSessionOptions
A detailed message may be now given rather than a simple boolan when forcing a new session.

Fixes eclipse-theia#12612

Contributed on behalf of ST Microelectronics

How to test

  1. Install following extension:
  1. The extension provides a set of commands that simulate the login using a dummy authentification provider. These commands all have a label starting with 'Auth-Test'.
  • Get all sessions lists all current sessions or undefined if none exist
  • Get session with no option gets the session with the default options. It won't create a new one by default, so no session will be displayed if used first
  • Get session with creationIfNone will get any existing session or create a new one if none exists
  • Get session with forceNewSession will force a new session (forceNewSession is true). Prompt a message with default content.
  • Get session with forceNewSession and detail will force a new session (forceNewSession is AuthenticationForceNewSessionOptions with an existing detail string). Prompt a message with content and detail message.

  1. On master theia, after creating an new session. Invoke Get session with forceNewSession command or Get session with forceNewSession and detail command will always lead to the same result. The message dialog to allow the new session always have the same message.

  2. Switch to this PR and run the same tests. The dialog will contain additional detail in the prompt dialog: 'Message based on detail for the force New Session' if Get session with forceNewSession and detail command is invoked.

Review checklist

Reminder for reviewers

@rschnekenbu
Copy link
Author

As a note, the changelog will be updated when added to the main repo

@rschnekenbu
[vscode] support AuthenticationForceNewSessionOptions with detail mes…
7d9d1d4 
…sage

* Defines and supports this new type in the authentification service.
* Updates prompt when new session is forced if detail message is present.

Contributed on behalf of STMicroelectronics
@rschnekenbu
Copy link
Author

closed in favor of eclipse-theia#12752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vscode] Support AuthenticationForceNewSessionOptions
1 participant
@rschnekenbu