Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for FileService & FileSystemProvider #9

Closed
wants to merge 1 commit into from

Conversation

tortmayr
Copy link

@tortmayr tortmayr commented Oct 1, 2020

Signed-off-by: Tobias Ortmayr tortmayr@eclipsesource.com
Contributed on behalf of STMicroelectronics

Copy link
Member

@koegel koegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions and a question

packages/filesystem/src/browser/file-service.ts Outdated Show resolved Hide resolved
packages/filesystem/src/browser/file-service.ts Outdated Show resolved Hide resolved
packages/filesystem/src/browser/file-service.ts Outdated Show resolved Hide resolved
fixes eclipse-theia#8599

Contributed on behalf of STMicroelectronics
Signed-off-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
Signed-off-by: Stefan Dirix <sdirix@eclipsesource.com>
@sdirix
Copy link
Member

sdirix commented Nov 16, 2022

Merged upstream with eclipse-theia#8596

@sdirix sdirix closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants