Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CTest for CI and add NVHPC 23.5 to CI testing #56

Merged
merged 11 commits into from
Aug 9, 2023

Conversation

reuterbal
Copy link
Collaborator

@reuterbal reuterbal commented Jul 11, 2023

Original intention was just to add a newer NVHPC version to Github CI but it went sideways pretty badly. Reason being that NVHPC seems to apply unsafe vectorization code paths that fail on the tail block when running with larger NPROMA values. Catering for too many different launch configurations in the runner script becomes unnecessarily complicated, since known good configurations are already encoded as ctests in the CMake configuration. Therefore, I've switched the CI runs to use CTest now (but kept the target validation in place).

@reuterbal reuterbal force-pushed the nabr-nvidia-ci branch 3 times, most recently from fffdd81 to bf5c149 Compare July 24, 2023 09:11
@reuterbal reuterbal changed the title Add NVHPC 23.5 to CI testing Switch to CTest for CI and add NVHPC 23.5 to CI testing Jul 24, 2023
@reuterbal reuterbal requested a review from mlange05 July 24, 2023 11:58
@reuterbal reuterbal marked this pull request as ready for review July 24, 2023 12:34
@reuterbal reuterbal force-pushed the nabr-nvidia-ci branch 10 times, most recently from c8e0273 to 0749717 Compare July 24, 2023 15:17
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look neat, and seem to reduce the test matrix quite significantly. As far as I can see there is no loss of functionality (only some error norm logging) that gets lost in using ctest, so all good from me, and GTG.

run: sudo apt-get install libopenmpi-dev

# Free up disk space for nvhpc
- name: Free Disk Space (Ubuntu)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@mlange05 mlange05 merged commit c4206f2 into develop Aug 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants