SYCL-specific env and README entry #68
Conversation
|
Once this is in, I think I'm happy with PR #64. @MichaelSt98 please have a look if this is ok and merge if you're happy with it. |
There was a problem hiding this comment.
Many thanks! Looks good and I just tested it.
The only thing to change is maybe to remove set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Xcuda-ptxas --maxrregcount=128").
On this note: without -fsycl-early-optimizations performance is significantly reduced! Maybe some (optimisation) flags can improve the performance even further (of course not relevant here, just to mention it).
| set(CMAKE_CXX_FLAGS "-O3 -L/home/nams/opt/dpcpp/lib -fopenmp -lstdc++") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsycl-early-optimizations -fsycl") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsycl-targets=nvptx64-nvidia-cuda") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Xcuda-ptxas --maxrregcount=128") |
There was a problem hiding this comment.
Just tested. We can drop set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Xcuda-ptxas --maxrregcount=128") as those flags are not used for the compilation/linking.
There was a problem hiding this comment.
Ok, cool, thanks for checking. I'll drop those and merge this into the main PR then.
|
Ok, test failures seem to be due to outdated loki-config. I'll merge this and rebase on the original PR to get this ready then. |
Additional encoding of the build settings in a dedicated env with a custom DPCPP install, and a short README description.
Note, it's nothing fancy but it should be enough to make it easily accessible.