Mark projects no longer as optional and fix field-api to v0.3.0 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlange05
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Ok, as discussed offline, I'm not a huge fan of forcing every repo to be checked out always, as some of them are large and only used for specific sub-options. However, ecbundle will always attempt to do so, only that it will fail silently without these flags, so this is beyond our control at this point.
But regardless of ecbundle's limitations, this looks good as is for our testing pipeline. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another annoying oversight: The correct field-api tag name is
v0.3.0(and not0.3.0). But the field-api project was marked as optional (to gracefully ignore that the field-api dependency could not be downloaded when it was still hosted internally). With field-api now available on Github, it should no longer be necessary to mark it as optional, ensuring we fail in the bundle creation when a tag is invalid.