Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cudafor import in driver for SCC CUF #157

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

reuterbal
Copy link
Collaborator

Hotfix for failing transformation of CLOUDSC (see https://github.com/ecmwf-ifs/dwarf-p-cloudsc/actions/runs/6275881222/job/17044373035)

This is fallout from the recent removal of Transformation recursion, where previously the import was injected into the driver module. No tests had been verifying this. Now it is instead added to the driver subroutine and checked in the tests.

@github-actions
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/157/index.html

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #157 (7c7a75d) into main (2322c1b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   92.09%   92.11%   +0.01%     
==========================================
  Files          90       90              
  Lines       16664    16659       -5     
==========================================
- Hits        15347    15345       -2     
+ Misses       1317     1314       -3     
Flag Coverage Δ
lint_rules 96.22% <ø> (ø)
loki 92.04% <ø> (ø)
transformations 91.61% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
transformations/transformations/scc_cuf.py 91.23% <100.00%> (+0.76%) ⬆️

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, nice fix! I can confirm this works, so GTG from me.

@reuterbal reuterbal merged commit edc54f8 into main Sep 25, 2023
12 checks passed
@reuterbal reuterbal deleted the nabr_fix_scc_cuf branch September 25, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants