Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add Condition #15

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Feature: Add Condition #15

merged 10 commits into from
Sep 23, 2024

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Sep 19, 2024 •
edited
Loading

  • Stores data as a dictionary
  • Can be made from xarray, earthkit, numpy, or dict
  • Can be exported to array

Closes #16

@HCookie
Feature: Add Condition
7857a34 
- Stores data as a dictionary
- Can be made from xarray, earthkit, numpy, or dict
- Can be exported to array
@HCookie
Update CHANGELOG
c067e1b
@HCookie HCookie added the enhancement New feature or request label Sep 19, 2024
@HCookie HCookie added this to the Rebuild Inference milestone Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (5b5536b) to head (56d7508).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #15      +/-   ##
===========================================
+ Coverage    85.50%   88.76%   +3.25%     
===========================================
  Files            2        3       +1     
  Lines           69       89      +20     
===========================================
+ Hits            59       79      +20     
  Misses          10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HCookie HCookie self-assigned this Sep 19, 2024
b8raoult
b8raoult previously approved these changes Sep 19, 2024
View reviewed changes
@HCookie HCookie marked this pull request as ready for review September 19, 2024 14:31
@HCookie HCookie requested a review from mchantry September 19, 2024 14:34
gmertes
gmertes requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! Just some minor comments.

src/anemoi/inference/condition.py Outdated Show resolved Hide resolved
tests/test_condition.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/anemoi/inference/condition.py Outdated Show resolved Hide resolved
@gmertes gmertes merged commit 004cf13 into develop Sep 23, 2024
97 checks passed
@gmertes gmertes deleted the feature/add_data_class branch September 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b8raoult b8raoult b8raoult left review comments

@gmertes gmertes gmertes approved these changes

@theissenhelen theissenhelen Awaiting requested review from theissenhelen theissenhelen is a code owner

@JesperDramsch JesperDramsch Awaiting requested review from JesperDramsch JesperDramsch is a code owner

@mchantry mchantry Awaiting requested review from mchantry mchantry is a code owner

Assignees

@HCookie HCookie

Labels
enhancement New feature or request
Projects
None yet
Milestone
Rebuild Inference
Development

Successfully merging this pull request may close these issues.

Add Data Management Class
4 participants
@HCookie @codecov-commenter @gmertes @b8raoult