Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Fixes to callback plots #182

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

OpheliaMiralles
Copy link
Contributor

  • plot_histogram: add density=True in call to np.histogram in order to get density values and not frequencies;
  • plot_sample: input precipitation currently does not use the same special colormap as the target/pred precipitation sample, which is fixed in this PR
  • plot_spectrum: add min_delta argument to the PlotSpectrum object to define a lower bound on the delta latitude value used to build the numpy array used for computation of power spectra. The current value is 0.0003 deg, which corresponds to 1km.

Fixes #179

@FussyDuck
Copy link

FussyDuck commented Dec 4, 2024

CLA assistant check
All committers have signed the CLA.

@OpheliaMiralles
Copy link
Contributor Author

@gabrieloks any news on this PR? I think all of the tests should pass now, I updated the code with develop today.

@gabrieloks
Copy link
Contributor

@gabrieloks any news on this PR? I think all of the tests should pass now, I updated the code with develop today.

I plan to test it later today :). I also have some doubts about hard-coding 0.0003 into the code. I think this should be specified in the config files

Copy link
Contributor

@gabrieloks gabrieloks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot for fixing this !

@gabrieloks gabrieloks merged commit da26cb7 into ecmwf:develop Dec 10, 2024
16 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpectralPlot callback produces TiB size numpy _ArrayMemoryError
3 participants