This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Fix/stretched grid check #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietervdb-meteo
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Code looks good. Tested on training of lam model with minimal config and graph from disk. This closes #203 .
icedoom888
pushed a commit
to MeteoSwiss/anemoi-training
that referenced
this pull request
Dec 17, 2024
* Identify stretched grid from graph * Code quality improvements * Added change log entry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the forecaster, there is a need to identify if we are dealing with a stretched grid model. The improvement in this PR also works if an existing graph is loaded from disk, in combination with a minimal config file specification of the graph.
This code update has been checked for stretched grid models.
Review suggestion (RMI): check if this change also works for LAM models when loading an existing graph from disk using a minimal configuration script.