Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saving frequency bug for inference checkpoints #37

Conversation

anaprietonem
Copy link
Contributor

Describe your changes

Current AnemoiCheckpoint allows to save the training and inference checkpoint with just one object by defining a custom _save_checkpoint method to handle this. However we also need to overwrite the _remove_checkpoint method to handle the removal of both training and inference checkpoint according to the settings defined in the eval_rollout.yaml config

Please also include relevant motivation and context.
PR is associated to this issue https://github.com/ecmwf-lab/aifs-mono/issues/257

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Issue ticket number and link

Ticket number - 257
https://github.com/ecmwf-lab/aifs-mono/issues/257

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation and docstrings to reflect the changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured that the code is still pip-installable after the changes and runs
  • I have not introduced new dependencies in the inference partion of the model
  • I have ran this on single GPU
  • I have ran this on multi-GPU or multi-node
  • I have ran this to work on LUMI (or made sure the changes work independently.)
  • I have ran the Benchmark Profiler against the old version of the code

Tag possible reviewers

You can @-tag people to review this PR in addition to formal review requests.

@FussyDuck
Copy link

FussyDuck commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

@anaprietonem anaprietonem added the bug Something isn't working label Aug 20, 2024
Copy link
Collaborator

@theissenhelen theissenhelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@theissenhelen theissenhelen merged commit 739b18d into develop Sep 2, 2024
108 checks passed
@theissenhelen theissenhelen deleted the 257-bug-inference-checkpoints-saving-frequency-ignoring-config-settings branch September 2, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants